-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLDB-1829 jseval rows #548
base: master
Are you sure you want to change the base?
Conversation
jeremybarnes
commented
Jul 20, 2016
•
edited
Loading
edited
- Fixes crashes with JS contexts being mixed within jseval
- Adds an ExpressionValue type to JS that mirrors the real one
- Allows for arguments to be passed through in non-simplified form in jseval by adding a '!' to the variable names parameter, so that we can get full fidelity passing through jseval
- Moved js out of soa and into plugins/lang/js, removing the last hooks of the generic code to JS
Test failure is runner_test, which is completely unrelated and known spurious. |
only un-nests by one level. | ||
|
||
ExpressionValue objects are primarily used by the `jseval` function | ||
with simplified arguments off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a link to the description of simplified arguments.
+1 I reviewed briefly the code with only minor comments. I don't no the js code that well. I agree with @FinchPowers that the exclamation mark might be confusing. |
J'ai fait une expérience. Dataset
Requête
Résultat
Il me semble que chaque colonne est explosée en 3, soit le nom, la valeur et la date. Est-ce bien ce que l'on souhaite? Aussi, je pense que le nom de la première colonne est incorrect. Il devrait se terminer par
|
@FinchPowers that behaviour is exactly the same as master; there is no change to the behaviour without an exclamation point. Structures are unfortunately broken out as [ [ key, [ value, ts ] ], ... ] and this behaviour is maintained to avoid breaking existing jseval scripts. If you use |
Merci pour l'explication. |